Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rb 26 cart #35

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Feature/rb 26 cart #35

merged 13 commits into from
Jan 6, 2025

Conversation

Tanyaa-a
Copy link
Collaborator

@Tanyaa-a Tanyaa-a commented Dec 31, 2024

Description

add cartPage and cart functionality, delete book from cart, add book to cart from book page

Changes

  • DBRequests.jsx
  • Cart.jsx
  • Book.jsx

Related issues

Screenshots

  • add book to cart
    Screenshot 2024-12-30 at 3 41 09 PM

  • book added to cart
    Screenshot 2024-12-30 at 3 41 17 PM

  • if the user not logged in the cart is not visible
    Screenshot 2024-12-29 at 11 54 24 PM

  • if the cart is empty
    Screenshot 2024-12-29 at 11 54 46 PM

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for rebooksctd ready!

Name Link
🔨 Latest commit cc744cd
🔍 Latest deploy log https://app.netlify.com/sites/rebooksctd/deploys/677b765ddcde5c00080b6d54
😎 Deploy Preview https://deploy-preview-35--rebooksctd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@in43sh in43sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job in this PR! Other than some small things, I noticed that adding to the cart doesn't always work for me properly: I can't add some books, and after adding some books I'm not being redirected to the /cart page. Also, I'm getting some console errors when trying to delete items from the cart.

.env.example Outdated Show resolved Hide resolved
src/api/DBRequests.jsx Show resolved Hide resolved
src/api/DBRequests.jsx Show resolved Hide resolved
src/pages/books/Book.jsx Outdated Show resolved Hide resolved
src/pages/books/Book.jsx Outdated Show resolved Hide resolved
src/pages/books/Book.jsx Outdated Show resolved Hide resolved
src/pages/cart/Cart.jsx Show resolved Hide resolved
src/pages/cart/Cart.jsx Outdated Show resolved Hide resolved
@Tanyaa-a Tanyaa-a requested a review from in43sh January 3, 2025 07:03
Copy link
Collaborator

@in43sh in43sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you split Cart into multiple components but after a closer look I saw some more improvements. After you fix those, I believe this PR should be good to go.

src/pages/cart/CartItem.jsx Outdated Show resolved Hide resolved
src/pages/cart/CartSummary.jsx Outdated Show resolved Hide resolved
src/pages/cart/CartItem.jsx Show resolved Hide resolved
src/pages/cart/CartSummary.jsx Show resolved Hide resolved
src/pages/cart/CartSummary.jsx Show resolved Hide resolved
src/pages/cart/CartSummary.jsx Outdated Show resolved Hide resolved
src/pages/cart/CartItem.jsx Outdated Show resolved Hide resolved
@Tanyaa-a Tanyaa-a requested a review from in43sh January 5, 2025 06:03
@Tanyaa-a Tanyaa-a merged commit 2177c55 into dev Jan 6, 2025
4 checks passed
@Tanyaa-a Tanyaa-a deleted the feature/RB-26-Cart branch January 6, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants